Skip to content

linker-messages is warn-by-default again#153968

Open
jyn514 wants to merge 5 commits intorust-lang:mainfrom
jyn514:jyn/linker-warn-by-default
Open

linker-messages is warn-by-default again#153968
jyn514 wants to merge 5 commits intorust-lang:mainfrom
jyn514:jyn/linker-warn-by-default

Conversation

@jyn514
Copy link
Copy Markdown
Member

@jyn514 jyn514 commented Mar 16, 2026 •
edited
Loading

cc #136096

I ended up keeping it a lint and adding an option for lints to ignore -Dwarnings (there was already a lint that did that actually, it was just hard-coded in rustc_middle instead of in rustc_lint_defs like I'd expect). This allows people to actually see the warnings without them failing the build in CI.

View all comments

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 16, 2026
@jyn514
Copy link
Copy Markdown
Member Author

jyn514 commented Mar 16, 2026

@bors try job=dist-x86_64-llvm-mingw

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Mar 16, 2026

@jyn514: 🔑 Insufficient privileges: not in try users

@jyn514 jyn514 force-pushed the jyn/linker-warn-by-default branch 2 times, most recently from 4bab2bf to 51b5bec Compare March 16, 2026 19:07
@Mark-Simulacrum
Copy link
Copy Markdown
Member

Mark-Simulacrum commented Mar 16, 2026

@bors delegate=try

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Mar 16, 2026

✌️ @jyn514, you can now perform try builds on this pull request!

You can now post @bors try to start a try build.

@jyn514
Copy link
Copy Markdown
Member Author

jyn514 commented Mar 16, 2026

@bors try job=dist-x86_64-llvm-mingw

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot pushed a commit that referenced this pull request Mar 16, 2026
@bors
Auto merge of #153968 - jyn514:jyn/linker-warn-by-default, r=<try>
b4b60e5 
[wip] linker-messages is warn-by-default again


try-job: dist-x86_64-llvm-mingw
mati865
mati865 reviewed Mar 16, 2026
View reviewed changes
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Mar 16, 2026

☀️ Try build successful (CI)
Build commit: b4b60e5 (b4b60e52ad96d0fa939acd7acbb42509477ac78b, parent: 3645249d79dfb136b5d8de3ce153d19d6698d92d)

@jyn514
Copy link
Copy Markdown
Member Author

jyn514 commented Mar 17, 2026

awesome, let's try all the targets now.

@bors try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot pushed a commit that referenced this pull request Mar 17, 2026
@bors
Auto merge of #153968 - jyn514:jyn/linker-warn-by-default, r=<try>
2d58f0b 
[wip] linker-messages is warn-by-default again
@jyn514
Copy link
Copy Markdown
Member Author

jyn514 commented Mar 17, 2026

oh i forgot that try doesn't actually run all tests in this repo oops

@jyn514 jyn514 changed the title [wip] linker-messages is warn-by-default again linker-messages is warn-by-default again Mar 17, 2026
@jyn514 jyn514 force-pushed the jyn/linker-warn-by-default branch from 51b5bec to c2e1fa8 Compare March 17, 2026 08:15
@jyn514
Copy link
Copy Markdown
Member Author

jyn514 commented Mar 17, 2026

r? @mati865

@jyn514 jyn514 marked this pull request as ready for review March 17, 2026 08:15
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 17, 2026

Some changes occurred in src/tools/compiletest

cc @jieyouxu

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 17, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 17, 2026

r? @fmease

rustbot has assigned @fmease.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: codegen, compiler
  • codegen, compiler expanded to 69 candidates
  • Random selection from 13 candidates

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 31, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jyn514 jyn514 force-pushed the jyn/linker-warn-by-default branch from b1f00c4 to 809ff51 Compare March 31, 2026 15:42
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 31, 2026

compiletest directives have been modified. Please add or update docs for the
new or modified directive in src/doc/rustc-dev-guide/.

@rustbot rustbot added the A-run-make Area: port run-make Makefiles to rmake.rs label Mar 31, 2026
@jyn514
Copy link
Copy Markdown
Member Author

jyn514 commented Mar 31, 2026

i think https://rustc-dev-guide.rust-lang.org/tests/directives.html#controlling-when-tests-are-run already covers this.

@jyn514 jyn514 force-pushed the jyn/linker-warn-by-default branch 2 times, most recently from 9efbd1f to 248a6b9 Compare March 31, 2026 15:49
@jyn514 jyn514 mentioned this pull request Mar 31, 2026
Open
17 tasks
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jyn514 jyn514 force-pushed the jyn/linker-warn-by-default branch from 5338073 to 03f5b9a Compare April 8, 2026 07:21
@mati865
Copy link
Copy Markdown
Member

mati865 commented Apr 8, 2026

@bors r+

Thanks, given the silence in Zulip thread I consider the discussion resolved.

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 8, 2026

📌 Commit 03f5b9a has been approved by mati865

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 8, 2026
rust-bors bot pushed a commit that referenced this pull request Apr 9, 2026
@bors
Auto merge of #153968 - jyn514:jyn/linker-warn-by-default, r=mati865
acc31d4 
linker-messages is warn-by-default again

cc #136096 

I ended up keeping it a lint and adding an option for lints to ignore `-Dwarnings` (there was already a lint that did that actually, it was just hard-coded in rustc_middle instead of in rustc_lint_defs like I'd expect). This allows people to actually see the warnings without them failing the build in CI.
@rust-bors

This comment has been minimized.

Sign in to view
@rust-log-analyzer
Copy link
Copy Markdown
Collaborator

rust-log-analyzer commented Apr 9, 2026

The job dist-x86_64-solaris failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@rust-bors rust-bors bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 9, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 9, 2026

💔 Test for acc31d4 failed: CI. Failed job:

@jyn514
Copy link
Copy Markdown
Member Author

jyn514 commented Apr 10, 2026

I downgraded it for -Dwarnings but not for Cargo's build.warnings = deny :/

I kinda wish -D warnings didn't exist tbh, it feels like Cargo really is the place that overall build failures should exist.

Probably the right fix here is to teach Cargo about "capped level" warnings? Right now cargo is telling rustc the right lint level, and here we want it to be the other way around, we want something that tells cargo that linker_messages should never be denied.

I'll chat with the cargo team and see what we can agree on.

@jyn514 jyn514 mentioned this pull request Apr 10, 2026
Open
3 tasks
@mati865
Copy link
Copy Markdown
Member

mati865 commented Apr 10, 2026

Oh bummer. I can see how that flag is useful for build systems not relying on Cargo, so I doubt we'd be able to function without it.

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mati865 mati865 mati865 left review comments

Assignees

@mati865 mati865

Labels

A-compiletest Area: The compiletest test runner A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jyn514 @Mark-Simulacrum @rustbot @mati865 @rust-log-analyzer @RalfJung @fmease